This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
set DisputesHandler in initializer on Rococo
#3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
ordian
approved these changes
Sep 5, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
eskimor
reviewed
Sep 6, 2021
| @@ -585,7 +585,7 @@ impl runtime_parachains::inclusion::RewardValidators for RewardValidators { | |||
|
|
|||
| impl parachains_inclusion::Config for Runtime { | |||
| type Event = Event; | |||
| type DisputesHandler = (); | |||
| type DisputesHandler = ParasDisputes; | |||
There was a problem hiding this comment.
Shouldn't this be feature gated as well?
ordian
added a commit
that referenced
this pull request
Sep 6, 2021
* master: Add tests and modify as_vec implementation (#3715) Bump structopt from 0.3.22 to 0.3.23 (#3770) bump substrate and beefy (#3789) set `DisputesHandler` in initializer (#3788) Bump futures from 0.3.16 to 0.3.17 (#3742) Convert rococo chainspec to raw chainspec (#3785) feat/overseer: introduce closure init (#3775) comment out bridges runtime modules (broken) and update Rococo chain-spec (#3780) Add VoteLocking config (#3734) Enable disputes on rococo (#3764) XCM: Automatic Version Negotiation (#3736)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously set to
()and theDisputesHandleris the primary way for the initializer & inherent handler to communicate info to disputes. Without this, the runtime will drop all disputes.